On Thu, Feb 25, 2016 at 08:42:19AM -0600, Bjorn Helgaas wrote: > On Tue, Feb 23, 2016 at 06:24:00PM +0000, Keith Busch wrote: > > On Mon, Feb 22, 2016 at 04:10:24PM -0600, Bjorn Helgaas wrote: > > > + /* > > > + * If the window is below 4GB, clear IORESOURCE_MEM_64 so we can > > > + * put 32-bit resources in the window. > > > + * > > > + * There's no hardware reason why a 64-bit window *couldn't* > > > + * contain a 32-bit resource, but pbus_size_mem() computes the > > > + * bridge window size assuming a 64-bit window will contain no > > > + * 32-bit resources. __pci_assign_resource() enforces that > > > + * artificial restriction to make sure everything will fit. > > > + */ > > > > This sounds good to me. Thanks! > > > > > res = &vmd->dev->resource[VMD_MEMBAR1]; > > > upper_bits = upper_32_bits(res->end); > > > flags = res->flags & ~IORESOURCE_SIZEALIGN; > > Can you prepare a patch, that adds both comments, please? (The one > about how we assume BIOS assigns the BAR below 4GB, and the one I > drafted above.)
Yep, will send it out be end of today.
