Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote:

<snip>

>+int hns_roce_buf_alloc(
>+                      struct hns_roce_dev *hr_dev,
>+                      int size, int max_direct,
>+                      struct hns_roce_buf *buf)

<snip>  
        
>+
>+                      pages =
>+                              kmalloc(sizeof(*pages) * buf->nbufs,
>+                                      GFP_KERNEL);

<snip>

>+
>+                      buf->direct.buf = vmap(
>+                                              pages, buf->nbufs, VM_MAP,
>+                                              PAGE_KERNEL);

<snip>

>+      if (
>+              event_type != HNS_ROCE_EVENT_TYPE_CQ_ID_INVALID &&
>+              event_type != HNS_ROCE_EVENT_TYPE_CQ_ACCESS_ERROR &&
>+              event_type != HNS_ROCE_EVENT_TYPE_CQ_OVERFLOW) {
>+              dev_err(&hr_dev->pdev->dev,
>+                      "hns_roce_ib: Unexpected event type 0x%x on CQ %06x\n",
>+                      event_type, hr_cq->cqn);
>+              return;
>+      }

Although checkpatch does not complain, I find this semi-random adding of
newlines quite odd.

Reply via email to