On 01/06, Srivatsa Vaddagiri wrote: > > On Sat, Jan 06, 2007 at 07:30:35PM +0300, Oleg Nesterov wrote: > > Stupid me. Thanks. > > > > I'll try to do something else tomorrow. Do you see a simple soulution? > > Sigh ..I dont see a simple solution, unless we have something like > lock_cpu_hotplug() ..
I suspect this can't help either. The problem is that flush_workqueue() may be called while cpu hotplug event in progress and CPU_DEAD waits for kthread_stop(), so we have the same dead lock if work->func() does flush_workqueue(). This means that Andrew's change to use preempt_disable() is good and anyway needed. I am starting to believe we need some more intrusive changes in workquue.c. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
