Hi Rob,
On Fri, 2016-03-04 at 22:30 -0600, Rob Herring wrote:
> On Thu, Mar 03, 2016 at 05:39:14PM +0300, Alexey Brodkin wrote:
> >
> > This add DT bindings documentation for ARC PGU display controller.
> >
> > Signed-off-by: Alexey Brodkin <abrod...@synopsys.com>
> > Cc: Rob Herring <robh...@kernel.org>
> > Cc: Pawel Moll <pawel.m...@arm.com>
> > Cc: Mark Rutland <mark.rutl...@arm.com>
> > Cc: Ian Campbell <ijc+devicet...@hellion.org.uk>
> > Cc: Kumar Gala <ga...@codeaurora.org>
> > Cc: devicet...@vger.kernel.org
> > Cc: linux-snps-...@lists.infradead.org
> > ---
> >
> > Changes v1 -> v2:
> > * Clean-up
> Not really useful. What we like to see is what changed. Maintainers have
> short memories and don't remember what they said previously (unless
> comments are ignored).
That's understood :)
> >
> >
> > .../devicetree/bindings/display/snps,arcpgu.txt | 33
> > ++++++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/display/snps,arcpgu.txt
> >
> > diff --git a/Documentation/devicetree/bindings/display/snps,arcpgu.txt
> > b/Documentation/devicetree/bindings/display/snps,arcpgu.txt
> > new file mode 100644
> > index 0000000..57f3bc8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/snps,arcpgu.txt
> > @@ -0,0 +1,33 @@
> > +ARC PGU
> > +
> > +This is a display controller found on several development boards produced
> > +by Synopsys. The ARC PGU is an RGB streamer that reads the data from a
> > +framebuffer and sends it to a single digital encoder (usually HDMI).
> > +
> > +Required properties:
> > + - compatible: "snps,arcpgu"
> > + - reg: Physical base address and length of the controller's registers.
> > + - clocks: A list of phandle + clock-specifier pairs, one for each
> > + entry in 'clock-names'.
> > + - clock-names: A list of clock names. For ARC PGU it should contain:
> > + - "pxlclk" for the clock feeding the output PLL of the controller.
> > +
> > +Required sub-nodes:
> > + - port: The PGU connection to an encoder chip. The connection is modelled
> > + using the OF graph bindings specified in
> > + Documentation/devicetree/bindings/graph.txt.
> > +
> > +Example:
> > +
> > +/ {
> > + ...
> > +
> > + pgu@XXXXXXXX {
> > + compatible = "snps,arcpgu";
> > + reg = <0xXXXXXXXX 0x400>;
> > + clocks = <&clock_node>;
> > + clock-names = "pxlclk";
> Where's the port? Didn't you previously say it was optional?
Well I wanted to get rid of anything except bare minimal that is required for
that driver.
What I did miss in that clean-up is description above.
In particular "Required subnodes" section that still lists "port".
And frankly now I'm a bit lost with what should I put in that binding
description and what should not. Any comments here are much appreciated.
-Alexey
