On Sun, Jan 07, 2007 at 03:13:19PM +0000, Christoph Hellwig wrote:
> > +compat_sys_sysinfo(struct compat_sysinfo __user *info)
> > +{
> > + extern int do_sysinfo(struct sysinfo *info);
>
> Please always put prototypes for functions with external linkage in
> header files.
>
Ah, crud, I stuck that there to reduce the number of patched files when I let
Thibaut test it, but forgot to remove it from the final patch.
> > +int do_sysinfo(struct sysinfo *info)
> > {
> > - struct sysinfo val;
> > unsigned long mem_total, sav_total;
> > unsigned int mem_unit, bitcount;
> > unsigned long seq;
> >
> > - memset((char *)&val, 0, sizeof(struct sysinfo));
> > + memset((char *)info, 0, sizeof(struct sysinfo));
>
> No need for the cast here.
>
Ok.
>
>
> Btw, in case you have some spare time there are some other syscalls
> that want similar treatment. sendfile(64) come to mind as these
> could use a do_sendfile helper aswell, the various stat and readdir/getdents
> variants could do with some unification, the various timing calls
> like alarm and get/settimeofday are common across architectures,
> sysctl should be the same everywhere, the uid/git related syscalls
> should be consolidated, sched_rr_get_interval looks trivial,
> and last but not least we probably want a unified mechanisms to deal
> with the 64bit arguments that are broken up into two 32bit ones (not just
> for emulation but also for 32it BE architectures)
>
I can definitely look into this.
> Okay, okay - we should probably put this into a Wiki somewhere :)
>
Heh. :)
Cheers,
Kyle
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
