On Tue, Mar 08, 2016 at 05:10:17PM -0600, Bjorn Helgaas wrote: > Hi Michael, > > On Tue, Mar 08, 2016 at 04:34:41PM -0600, Michael Auchter wrote: > > Add a stub for pci_clear_master() for when CONFIG_PCI is not set, > > similar to what's done for pci_set_master(). > > Does this fix a problem? If so, what is it? Some driver that doesn't > build when CONFIG_PCI is not set?
I ran into a build failure caused by this not being defined while compile testing an out-of-tree driver with various configs. It seemed to me that the lack of a stub may have just been an oversight from when pci_clear_master() was added. It looks like all in-tree users of pci_clear_master() correctly declare a dependency on PCI via Kconfig, so this doesn't really fix a problem, just makes pci_clear_master more symmetric with pci_set_master. Cheers, Michael
