Hi,
On 03/12/2016 08:22 PM, Peter Zijlstra wrote:
On Tue, Feb 23, 2016 at 08:12:36AM -0600, Suravee Suthikulpanit wrote:
From: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com>
First, this patch move arch/x86/events/amd/iommu.h to
arch/x86/include/asm/perf/amd/iommu.h so that we easily include
it in both perf-amd-iommu and amd-iommu drivers.
Then, we consolidate declaration of AMD IOMMU performance counter
APIs into one file.
These seem two independent thingies; should this therefore not be 2
patches?
Reviewed-by: Joerg Roedel <jroe...@suse.de>
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com>
---
arch/x86/events/amd/iommu.c | 2 +-
arch/x86/events/amd/iommu.h | 40 ---------------------------------
arch/x86/include/asm/perf/amd/iommu.h | 42 +++++++++++++++++++++++++++++++++++
That seems somewhat excessive. Not only do you create
arch/x86/include/asm/perf/ you then put another directory on top of
that.
The original header files (arch/x86/events/amd/iommu.h and
drivers/iommu/amd_iommu_proto.h) has duplicate function declarations.
So, with the new header file being in the
arch/x86/include/asm/perf/amd/iommu.h, we can just have one function
declaration.
So, you just want to separate the file moving part and the part that
removes of the duplication?
Thanks,
Suravee
