Mariusz Kozlowski writes: > This patch removes redundant argument check for of_node_get(). > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > arch/powerpc/sysdev/cpm2_pic.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/cpm2_pic.c > linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/cpm2_pic.c > --- linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/cpm2_pic.c 2006-12-24 > 05:00:32.000000000 +0100 > +++ linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/cpm2_pic.c 2007-01-02 > 02:04:25.000000000 +0100 > @@ -245,9 +245,7 @@ void cpm2_pic_init(struct device_node *n > cpm2_intctl->ic_scprrl = 0x05309770; > > /* create a legacy host */ > - if (node) > - cpm2_pic_node = of_node_get(node); > - > + cpm2_pic_node = of_node_get(node);
This is actually a semantic change, in that cpm2_pic_node always gets assigned now, whereas previously it didn't if node == NULL. Are you sure that is OK? If so, you need to add something to the patch description explaining why it is OK. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
