Benjamin Herrenschmidt wrote: > On Mon, 2007-01-08 at 16:56 -0800, Greg KH wrote: >> On Tue, Jan 09, 2007 at 11:38:59AM +1100, Benjamin Herrenschmidt wrote: >>> On Mon, 2007-01-08 at 15:58 +0100, Sylvain Munaut wrote: >>>> Don't build ohci as module for now. >>>> A fix for that is already in gregkh usb tree for 2.6.21 >>> Do you mean that as-is, powerpc defconfigs cannot build USB as a module >>> in 2.6.20 ? That is unacceptable as a regression. We need a fix in >>> 2.6.20. >>> >>> Greg, what is the status there ? >> Hm, for some reason I thought your patches were not needed until 2.6.21. > > My endian patches aren't, but Sylvain' are based on mines so ... Maybe > if Sylvain rebases his ?
FWIW, the patch does apply fine (at least the first one, which is needed) : [EMAIL PROTECTED] linux-2.6-mpc52xx-new $ patch -p1 --dry-run < ohci-rework-bus-glue-integration-to-allow-several-at-once.patch patching file drivers/usb/host/ohci-at91.c patching file drivers/usb/host/ohci-au1xxx.c patching file drivers/usb/host/ohci-ep93xx.c patching file drivers/usb/host/ohci-hcd.c patching file drivers/usb/host/ohci-lh7a404.c patching file drivers/usb/host/ohci-omap.c patching file drivers/usb/host/ohci-pci.c Hunk #1 succeeded at 238 (offset -73 lines). patching file drivers/usb/host/ohci-pnx4008.c patching file drivers/usb/host/ohci-pnx8550.c patching file drivers/usb/host/ohci-ppc-soc.c patching file drivers/usb/host/ohci-pxa27x.c patching file drivers/usb/host/ohci-s3c2410.c patching file drivers/usb/host/ohci-sa1111.c The offset in ohci-pci.c is harmless. But maybe the question we should ask is why would it build drivers/usb/host/ohci-ppc-soc.c for an iMac G3 ... Because that problem (ohci multiple glue in module) is there since a long time, just never spotted before. arch/powerpc/KConfig : config PPC_EFIKA bool "bPlan Efika 5k2. MPC5200B based computer" depends on PPC_MULTIPLATFORM && PPC32 select PPC_RTAS select RTAS_PROC select PPC_MPC52xx select PPC_NATIVE default y ^^^ This was added by commit c37858d333a50815c74349396e31a535f4128e0b on Nov5. and a patch to correct that has been submitted recently : http://patchwork.ozlabs.org/linuxppc/patch?id=8848 Sylvain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/