On Fri, 18 Mar 2016, kan.li...@intel.com wrote: > From: Kan Liang <kan.li...@intel.com> > > This patch makes Intel uncore pmu driver modular. > By default, the uncore driver will be built in the kernel. If it is > configured as module, the supported cpu model can be auto loaded. > This patch also cleans up the code of cpu_init and pci_init.
Nice work! > +static struct intel_uncore_init_fun skl_uncore_init = { > + .pci_init = skl_uncore_pci_init, > +}; > + > +static const struct x86_cpu_id intel_uncore_match[] = { Shouldn't all of these structs be const __initconst? Other than that: Reviewed-by: Thomas Gleixner <t...@linutronix.de>