On 03/18/2016 04:09 PM, Lee Jones wrote: > On Fri, 18 Mar 2016, Lu Baolu wrote: > >> Some Intel platforms have an USB port mux controlled by GPIOs. >> There's a single ACPI platform device that provides both USB ID >> extcon device and a USB port mux device. This MFD driver will >> split the 2 devices for their respective drivers. >> >> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> >> Suggested-by: David Cohen <david.a.co...@linux.intel.com> > This should be at the top. > > You couldn't have written the patch before it was suggested.
Yes. I will change this. > >> Reviewed-by: Felipe Balbi <ba...@kernel.org> >> Signed-off-by: Fengguang Wu <fengguang...@intel.com> > What is this sign-off meant to indicate? Fengguang's sign-off was added due to folding a patch contributed by his kbuild robot. https://lkml.org/lkml/2016/3/3/118 I will add this in commit message. > >> Reviewed-by: Lee Jones <lee.jo...@linaro.org> > Why is this here? > > a) I don't provide "Reviewed-by:" tags #alarmbells > b) I have never signed this patch off Sorry about this. I will remove this line. > >> --- >> MAINTAINERS | 6 ++++ > Seperate patch. If I make it in a separate patch, checkpatch.pl will give me below warning. " WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 " Is it forgivable? Best regards, Baolu > >> drivers/mfd/Kconfig | 8 +++++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/intel-vuport.c | 74 >> ++++++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 89 insertions(+) >> create mode 100644 drivers/mfd/intel-vuport.c > [...] >
