Hi Alexey,

Thank you for the patch.

On Monday 21 Mar 2016 15:28:40 Alexey Brodkin wrote:
> Now when generic drm_connector_register_all() helper exists we may safely

s/Now when/Now that a/

> substiture with it driver-specific implementation of connectors plugging in

s/substiture with it/substitute it for the/

> sysfs.

And while at it, in the subject line,

s/rcar-du - use/rcar-du: Use/

> Signed-off-by: Alexey Brodkin <abrod...@synopsys.com>
> Cc: Daniel Vetter <dan...@ffwll.ch>
> Cc: David Airlie <airl...@linux.ie>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: linux-renesas-...@vger.kernel.org

Apart for the commit message fixes,

Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

> ---
> 
> No changes v1 -> v2.
> 
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 644db36..0f251dc 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -361,14 +361,7 @@ static int rcar_du_probe(struct platform_device *pdev)
>       if (ret)
>               goto error;
> 
> -     mutex_lock(&ddev->mode_config.mutex);
> -     drm_for_each_connector(connector, ddev) {
> -             ret = drm_connector_register(connector);
> -             if (ret < 0)
> -                     break;
> -     }
> -     mutex_unlock(&ddev->mode_config.mutex);
> -
> +     ret = drm_connector_register_all(ddev);
>       if (ret < 0)
>               goto error;

-- 
Regards,

Laurent Pinchart

Reply via email to