On Mar 21 Arnd Bergmann wrote: > On Sunday 20 March 2016 22:59:11 Tina Ruchandani wrote: > > 'struct timeval' uses a 32 bit field for its 'seconds' value which > > will overflow in year 2038 and beyond. This patch replaces the use > > of timeval in nosy.c with timespec64 which doesn't suffer from y2038 > > issue. The code is correct as is - since it is only using the > > microseconds portion of timeval. However, this patch does the > > replacement as part of a larger effort to remove all instances of > > 'struct timeval' from the kernel (that would help identify cases > > where the code is actually broken). > > > > Signed-off-by: Tina Ruchandani <ruchandani.t...@gmail.com> > > --- > > drivers/firewire/nosy.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > The patch looks correct to me, but it seems the same one has > just been merged into mainline Linux on Saturday (the patch > was posted back in October). > > commit 2ae4b6b20e2004dccf80d804ae52b073377c2f5b [...]
No, Amitoj's patch from October changed nosy.c::packet_irq_hander, whereas Tina' patch changes nosy.c::bus_reset_irq_handler. IOW the new patch completes what the former patch (and us reviewers) missed. -- Stefan Richter -======----- --== =-=-= http://arcgraph.de/sr/
