ext Pierre Ossman wrote: > I've queued it up for -mm, but there a few more comments I want resolved > before this can move to Linus...
Ok, thanks for the revisions. > > You need to clean up mmc_lockable_store(). It had a few broken variable > declarations that even prevented it from compiling, and after I fixed > that I still get: > > drivers/mmc/mmc_sysfs.c: In function ‘mmc_lockable_store’: > drivers/mmc/mmc_sysfs.c:160: warning: ignoring return value of > ‘device_attach’, declared with attribute warn_unused_result > drivers/mmc/mmc_sysfs.c:93: warning: ‘mmc_key’ may be used uninitialized > in this function I did a modification at this patch and did not get those warnings anymore. > > There's also no handling for an invalid string written to the sysfs node. Is this really needed? I thought the function just ignored other values sent to itself that were not handled. > > And third, you're a bit excessive on the goto:s. E.g. out_unlocked is > used in a single place, so it is completely unnecessary. Please do a > general cleanup of the control flow. Ok. Regards, Anderson Briglia - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
