2016-03-22 22:02 GMT+09:00 Greg KH <gre...@linuxfoundation.org>: > On Tue, Mar 22, 2016 at 04:40:24PM +0900, DaeSeok Youn wrote: >> 2016-03-22 6:05 GMT+09:00 Greg KH <gre...@linuxfoundation.org>: >> > On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote: >> >> the tty_alloc_driver() can allocate memory for ttys and termios. >> >> And also it can release allocated memory easly with using >> >> put_tty_driver(). >> >> >> >> Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> >> > >> > But you broke the driver in the previous patch, you can't do that, each >> > patch has to be 'stand-alone'. >> I am not sure about 'stand-alone'. this patch has to have dependency on >> previous patch.. > > Yes, that is ok, but your first patch said it was just function > renaming, and then the second patch broke functionality, and the third > fixed it up. You should have a working kernel at each step in your > patch series, which you did not. I got it. So I start over from fixing coding style of dgnc module like I was doing dgap module.
> >> And I have a question not related this thread, >> I had been waiting my patches merged and also have other patches on >> same file(in case of dgnc). >> I couldn't send next patches until previous patches are taken. >> How can I manage my patches for this case? > > Just send your new patches and say they depend on the previous ones. My > staging patch queue is almost empty at the moment so odds are I have > already applied, or rejected them. thanks for your explanation. :-) I will try to make patches more carefully. regards, Daeseok. > > thanks, > > greg k-h
