On Wed, 2016-03-23 at 09:51 +0100, Borislav Petkov wrote: > On Tue, Mar 22, 2016 at 03:40:45PM -0600, Toshi Kani wrote: > > Will change to "Prevent the OS from initializing the PAT MSR". > > > > I wanted to clarify that "disable" does not mean to disable PAT MSR. > > How do you "disable PAT MSR" ?
We can't, but I thought not everyone knows how it works... > I think you're overdocumenting this. pat_disable() is as clear as day > what it does. It doesn't need any commenting... Right, maybe I am just paranoid. I will remove the comment as you suggested. > > I've run checkpatch.pl and thought it was OK to have this warning > > (instead of a >80 warning) since the error message part was not split. > > The "attempting" part is for debugging and its string is passed from > > the caller. > > We always put the quoted strings on a single line for easier grepping. > Forget the 80-cols rule. OK. Thanks, -Toshi
