On Wed, Mar 23, 2016 at 9:22 PM, Srinivas Pandruvada
<srinivas.pandruv...@linux.intel.com> wrote:
> On Wed, 2016-03-23 at 12:43 -0400, Linda Knippers wrote:
>> I raised a general concern on a previous patch so I found a 1P server
>> with Skylake and HWP to try. This doesn't qualify as a tested-by
>> since all I did was apply the patch and boot the server but hey, it
>> booted.
> Thanks.
>
>>
>> I do have a question below...
>>
> [...]
>> + if (ACPI_SUCCESS(acpi_run_osc(handle, &osc_context))) {
>> > + acpi_hwp_native_thermal_lvt_set = true;
>> > + kfree(osc_context.ret.pointer);
>>
>> There are other boot messages that indicate when something is
>> happening
>> with _OSC. Should there be one for this? Or is there some other
>> obvious
>> way one can know that this was set?
>>
> I am following model of acpi_bus_osc_support, which issues _OSC for
> global platform scope, where nothing is getting printed. If it is
> useful, I don't mind adding a print.
>
> Rafael,
> What do you think?
Printing a message after acpi_run_osc() has been called successfully
shouldn't hurt. Maybe using acpi_handle_info()?
Thanks,
Rafael
