Rasmus Villemoes <li...@rasmusvillemoes.dk> : > We need to use post-decrement to ensure that irq_dispose_mapping is > also called on priv->rxq[0]->irq_no; moreover, if one of the above for > loops failed already at i==0 (so we reach one of these labels with > that value of i), we'll enter an essentially infinite loop of > out-of-bounds accesses. > > Signed-off-by: Rasmus Villemoes <li...@rasmusvillemoes.dk>
(ok, i is signed) Reviewed-by: Francois Romieu <rom...@fr.zoreil.com> Someone messed with my review on 2014/03/25 and got it wrong. :o/ Two years after the initial submission, there is zero change regarding use of sxgbe_core_ops for extension or manageability. The extra indirection is ripe for removal during next net-next. -- Ueimor
