Hi Jon, On Thu, Mar 17, 2016 at 3:19 PM, Jon Hunter <jonath...@nvidia.com> wrote: > --- a/drivers/irqchip/irq-gic.c > +++ b/drivers/irqchip/irq-gic.c
> -#ifdef CONFIG_SMP > - set_smp_cross_call(gic_raise_softirq); > - register_cpu_notifier(&gic_cpu_notifier); > -#endif > + if (gic_nr == 0) { > + if (IS_ENABLED(CONFIG_SMP)) { > + set_smp_cross_call(gic_raise_softirq); If CONFIG_SMP=n: drivers/irqchip/irq-gic.c: In function '__gic_init_bases': drivers/irqchip/irq-gic.c:1165:4: error: implicit declaration of function 'set_smp_cross_call' [-Werror=implicit-function-declaration] set_smp_cross_call(gic_raise_softirq); ^ There's no dummy for the CONFIG_SMP=n case, so you either have to keep the #ifdef, or add a dummy. > + register_cpu_notifier(&gic_cpu_notifier); > + } -- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds