Removing two "!= NULL" from fwserial.c as suggested by checkpatch.pl.
Note that the associated expression "port->port.console" is a 1-bit-field
that is already assumed as an implicit boolean (that is: without comparison)

Signed-off-by: Dominique van den Broeck <domdev...@free.fr>
---
 drivers/staging/fwserial/fwserial.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fwserial/fwserial.c 
b/drivers/staging/fwserial/fwserial.c
index 66e54e7..4dd5304 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1701,7 +1701,7 @@ static void fwserial_virt_plug_complete(struct fwtty_peer 
*peer,
        dma_fifo_change_tx_limit(&port->tx_fifo, port->max_payload);
        spin_unlock_bh(&peer->port->lock);
 
-       if (port->port.console && port->fwcon_ops->notify != NULL)
+       if (port->port.console && port->fwcon_ops->notify)
                (*port->fwcon_ops->notify)(FWCON_NOTIFY_ATTACH, port->con_data);
 
        fwtty_info(&peer->unit, "peer (guid:%016llx) connected on %s\n",
@@ -1808,7 +1808,7 @@ static void fwserial_release_port(struct fwtty_port 
*port, bool reset)
        RCU_INIT_POINTER(port->peer, NULL);
        spin_unlock_bh(&port->lock);
 
-       if (port->port.console && port->fwcon_ops->notify != NULL)
+       if (port->port.console && port->fwcon_ops->notify)
                (*port->fwcon_ops->notify)(FWCON_NOTIFY_DETACH, port->con_data);
 }
 
-- 
2.4.3

Reply via email to