Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types

[Mark Brown]

On Tue, Mar 29, 2016 at 03:58:40PM -0700, Stephen Boyd wrote:

> -     if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS) {
> -             ret = spmi_regulator_ftsmps_init_slew_rate(vreg);
> +     if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS ||
> +         vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_LO_SMPS ||
> +         vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_HO_SMPS ||
> +         vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_SMPS) {
> +             ret = spmi_regulator_init_slew_rate(vreg);

This should be a switch statement.  Otherwise this looks fine.

signature.asc
Description: PGP signature