Hi Vinod,
> -----Original Message-----
> From: Vinod Koul [mailto:vinod.k...@intel.com]
> Sent: Wednesday, April 06, 2016 9:05 PM
> To: Appana Durga Kedareswara Rao <appa...@xilinx.com>
> Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com;
> ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; Michal Simek
> <mich...@xilinx.com>; Soren Brinkmann <sor...@xilinx.com>;
> dan.j.willi...@intel.com; Appana Durga Kedareswara Rao
> <appa...@xilinx.com>; moritz.fisc...@ettus.com;
> laurent.pinch...@ideasonboard.com; l...@debethencourt.com; Srikanth
> Vemula <svem...@xilinx.com>; Anirudha Sarangi <anir...@xilinx.com>;
> devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> ker...@vger.kernel.org; dmaeng...@vger.kernel.org
> Subject: Re: [RESEND PATCH v2 3/6] Documentation: DT: vdma: update binding
> doc for AXI DMA
>
> On Wed, Apr 06, 2016 at 10:44:57AM +0530, Kedareswara rao Appana wrote:
> > This patch updates the device-tree binding doc for adding support for
> > AXI DMA.
> >
> > Signed-off-by: Kedareswara rao Appana <appa...@xilinx.com>
> > ---
> > Changes for v2:
> > ---> Modified commit message as suggested by Vinod.
> > ---> Moved the patch to forward in the series as suggested by vinod.
> >
> > .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 22
> > +++++++++++++++++++++-
> > 1 file changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > index a86737c..5841421 100644
> > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > @@ -3,8 +3,13 @@ It can be configured to have one channel or two
> > channels. If configured as two channels, one is to transmit to the
> > video device and another is to receive from the video device.
> >
> > +Xilinx AXI DMA engine, it does transfers between memory and AXI4
> > +stream target devices. It can be configured to have one channel or two
> channels.
> > +If configured as two channels, one is to transmit to the device and
> > +another is to receive from the device.
> > +
> > Required properties:
> > -- compatible: Should be "xlnx,axi-vdma-1.00.a"
> > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> > - #dma-cells: Should be <1>, see "dmas" property below
> > - reg: Should contain VDMA registers location and length.
> > - xlnx,num-fstores: Should be the number of framebuffers as configured in
> h/w.
> > @@ -59,6 +64,21 @@ axi_vdma_0: axivdma@40030000 {
> > } ;
> > } ;
> >
> > +axi_dma_0: axidma@40400000 {
>
> Why have you ignored Robs comment on this? Ideally you should have posted
> these fixed.
I just resent the patch series as you requested.
Will fix Rob's comments and will send v3...
Regards,
Kedar.
>
> > + compatible = "xlnx,axi-dma-1.00.a";
> > + #dma-cells = <1>;
> > + reg = < 0x40400000 0x10000 >;
> > + dma-channel@40400000 {
> > + compatible = "xlnx,axi-dma-mm2s-channel";
> > + interrupts = < 0 59 4 >;
> > + xlnx,datawidth = <0x40>;
> > + } ;
> > + dma-channel@40400030 {
> > + compatible = "xlnx,axi-dma-s2mm-channel";
> > + interrupts = < 0 58 4 >;
> > + xlnx,datawidth = <0x40>;
> > + } ;
> > +} ;
> >
> > * DMA client
> >
> > --
> > 2.1.2
> >
>
> --
> ~Vinod
