Hi Vinod, > -----Original Message----- > From: Koul, Vinod [mailto:vinod.k...@intel.com] > Sent: Thursday, April 07, 2016 5:53 AM > To: Soren Brinkmann <sor...@xilinx.com> > Cc: l...@metafoo.de; linux-kernel@vger.kernel.org; pawel.m...@arm.com; > Appana Durga Kedareswara Rao <appa...@xilinx.com>; > l...@debethencourt.com; moritz.fisc...@ettus.com; robh...@kernel.org; > Srikanth Vemula <svem...@xilinx.com>; Michal Simek <mich...@xilinx.com>; > Anirudha Sarangi <anir...@xilinx.com>; devicet...@vger.kernel.org; Soren > Brinkmann <sor...@xilinx.com>; Williams, Dan J <dan.j.willi...@intel.com>; > mark.rutl...@arm.com; ga...@codeaurora.org; ijc+devicet...@hellion.org.uk; > dmaeng...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > laurent.pinch...@ideasonboard.com > Subject: Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan > prefix to dma-chan > > On Wed, 2016-04-06 at 16:00 -0700, Sören Brinkmann wrote: > > On Wed, 2016-04-06 at 22:13:59 +0000, Koul, Vinod wrote: > > > On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > > > > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > > > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > > > > +++ > > > > > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.t > > > > > > > xt > > > > > > > @@ -24,8 +24,8 @@ Optional properties: > > > > > > > {3}, flush s2mm channel > > > > > > > > > > > > > > Required child node properties: > > > > > > > -- compatible: It should be either "xlnx,axi-vdma-mm2s > > > > > > > -channel" > > > > > > > or > > > > > > > - "xlnx,axi-vdma-s2mm-channel". > > > > > > > +- compatible: It should be either "xlnx,axi-dma-mm2s > > > > > > > -channel" > > > > > > > or > > > > > > > + "xlnx,axi-dma-s2mm-channel". > > > > > > > > > > > > This change is not backwards compatible and breaks every user > > > > > > of the current binding. > > > > > > > > > > This commit > > > > > http://git.kernel.org/cgit/linux/kernel/git/vkoul/slave- > > > > > > dma.git/commit/?h=next&id=8e66e7d682b04f7141f8ae666908c8dcd7fc0b > > > > > fa > > > > > Renames xilinx_vdma_ prefix to xilinx_dma which includes > > > > > renaming of the above properties. > > > > > > That patch changes driver from vdma to dma. It does not change > > > property name! > > > > It does. Unfortunately there are no line numbers on that website, > > hence here an excerpt from the commit you mention: > > @@ -1220,26 +1220,26 @@ static int xilinx_vdma_chan_probe(struct > > xilinx_vdma_device *xdev, > > if (!has_dre) > > xdev->common.copy_align = fls(width - 1); > > > > - if (of_device_is_compatible(node, "xlnx,axi-vdma-mm2s > > -channel")) { > > + if (of_device_is_compatible(node, "xlnx,axi-dma-mm2s > > -channel")) { > > chan->direction = DMA_MEM_TO_DEV; > > chan->id = 0; > > Right, missed that somehow. > > Am dropping the patch
Will fix this part and will include this patch in v4 series... Regards, Kedar. > > -- > ~Vinod
