On 04/02/2016 05:12 AM, Mike Galbraith wrote: >> By the time I improved hotplug I played with this. I had a few ideas but >> it didn't fly in the end. Today however I ended up with this: > > Yeah, but that fails the duct tape test too. Mine is below, and is the > extra sticky variety ;-) With busted 0299 patch reverted and those two > applied, my DL980 took a beating for ~36 hours before I aborted it.. ie > hotplug road seemingly has no more -rt specific potholes.
just to be clear: The patch I attached did _not_ work for you. > If that lock dies, we can unpin when entering lock slow path and pin > again post acquisition with no ABBA worries as well, and not only does > existing hotplug work heaping truckloads better, -rt can perhaps help > spot trouble as the rewrite proceeds. > > Current state is more broken than ever.. if that's possible. And the two patches you attached here did? > > -Mike Sebastian
