On Thu, Apr 07, 2016 at 02:16:29PM -0400, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 04/07/2016 08:30 AM, Krzysztof Kozlowski wrote: > > On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote: > >> The driver's init and exit function don't do anything besides registering > >> and unregistering the platform driver, so the module_platform_driver() > >> macro could just be used instead of having separate functions. > >> > >> Currently the macro is not being used because the driver is initialized at > >> subsys init call level but this isn't necessary since consumer devices are > >> defined in the DT as dependencies so there's no need for init calls order. > >> > >> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> > >> > >> --- > >> This patch was tested on an Exynos5422 Odroid XU4 board. > > > > This test might not be sufficient. XU4 is not a mobile device like many > > other users of this driver (except Arndale Octa and Artiks all of other > > users are mobiles/wearables). > > > > For example XU4 does not have USB OTG (like other devices and like XU3). > > > > All the consumer device nodes for these regulators are defined in the > exynos5422-odroidxu3-common.dtsi that is shared by all the Odroid XU* > so I thought testing in the XU4 was as good as testing in the XU3 > (since the USB OTG doesn't use a regulator from this PMIC). > > I've also checked the DTS for all the boards that use regulators that > are registered by this driver and all consumer drivers supports probe > deferral so I think this change is safe.
Ah, seems fine then! Thanks for checking. Best regards, Krzysztof
