On Wed, Apr 6, 2016 at 12:32 PM, YH Huang <[email protected]> wrote: > POWER_SUPPLY_STATUS_NOT_CHARGING is used for AC connected, but > battery not charging (e.g. because battery temperature is out > of acceptable range). > > When battery is charging near dry and BATTERY_FULL_DISCHARGED is set, > it is wrong to set as POWER_SUPPLY_STATUS_NOT_CHARGING. > Just use BATTERY_DISCHARGING to decide the power supply status is > discharging or charging. > > Signed-off-by: YH Huang <[email protected]>
Reviewed-by: Daniel Kurtz <[email protected]> > --- > drivers/power/sbs-battery.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs-battery.c > index d6226d6..768b9fc 100644 > --- a/drivers/power/sbs-battery.c > +++ b/drivers/power/sbs-battery.c > @@ -382,8 +382,6 @@ static int sbs_get_battery_property(struct i2c_client > *client, > > if (ret & BATTERY_FULL_CHARGED) > val->intval = POWER_SUPPLY_STATUS_FULL; > - else if (ret & BATTERY_FULL_DISCHARGED) > - val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING; > else if (ret & BATTERY_DISCHARGING) > val->intval = POWER_SUPPLY_STATUS_DISCHARGING; > else > @@ -702,8 +700,6 @@ static void sbs_delayed_work(struct work_struct *work) > > if (ret & BATTERY_FULL_CHARGED) > ret = POWER_SUPPLY_STATUS_FULL; > - else if (ret & BATTERY_FULL_DISCHARGED) > - ret = POWER_SUPPLY_STATUS_NOT_CHARGING; > else if (ret & BATTERY_DISCHARGING) > ret = POWER_SUPPLY_STATUS_DISCHARGING; > else > -- > 1.7.9.5 >
