On Tue, Jan 16, 2007 at 10:15:57PM +0100, Oliver Neukum wrote: > Am Dienstag, 16. Januar 2007 21:33 schrieb Alan Stern: > > Are you aware that your patch for safe attribute file removal provokes a > > lockdep warning at bootup? > > Yes, I am aware of that. However, the top down lock order is always > followed. A patch to make the lock checker realize that has been posted > and included upstream.
Alan, here's the patch: Signed-off-by: Frederik Deweerdt <[EMAIL PROTECTED]> diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index 8c533cb..3b5574b 100644 --- a/fs/sysfs/inode.c +++ b/fs/sysfs/inode.c @@ -214,7 +214,7 @@ static inline void orphan_all_buffers(st struct sysfs_buffer_collection *set = node->i_private; struct sysfs_buffer *buf; - mutex_lock(&node->i_mutex); + mutex_lock_nested(&node->i_mutex, I_MUTEX_CHILD); if (node->i_private) { list_for_each_entry(buf, &set->associates, associates) { down(&buf->sem); @@ -271,7 +271,7 @@ int sysfs_hash_and_remove(struct dentry return -ENOENT; parent_sd = dir->d_fsdata; - mutex_lock(&dir->d_inode->i_mutex); + mutex_lock_nested(&dir->d_inode->i_mutex, I_MUTEX_PARENT); list_for_each_entry(sd, &parent_sd->s_children, s_sibling) { if (!sd->s_element) continue; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/