On Sat, 16 Apr 2016 09:58:07 +0200 Boris Brezillon <[email protected]> wrote:
> On Fri, 15 Apr 2016 21:54:10 +0200 > Rafał Miłecki <[email protected]> wrote: > > > Now we have all drivers properly setting this new field we can start > > using it and proceed with deprecating NAND_ECC_SOFT_BCH. > > > > Signed-off-by: Rafał Miłecki <[email protected]> > > --- > > drivers/mtd/nand/nand_base.c | 98 > > ++++++++++++++++++++++++-------------------- > > 1 file changed, 53 insertions(+), 45 deletions(-) > > [...] > > @@ -4248,51 +4248,59 @@ int nand_scan_tail(struct mtd_info *mtd) > > ecc->algo = NAND_ECC_HAMMING; > > > > case NAND_ECC_SOFT: > > - ecc->calculate = nand_calculate_ecc; > > - ecc->correct = nand_correct_data; > > - ecc->read_page = nand_read_page_swecc; > > - ecc->read_subpage = nand_read_subpage; > > - ecc->write_page = nand_write_page_swecc; > > - ecc->read_page_raw = nand_read_page_raw; > > - ecc->write_page_raw = nand_write_page_raw; > > - ecc->read_oob = nand_read_oob_std; > > - ecc->write_oob = nand_write_oob_std; > > - if (!ecc->size) > > - ecc->size = 256; > > - ecc->bytes = 3; > > - ecc->strength = 1; > > - break; > > - > > case NAND_ECC_SOFT_BCH: > > Shouldn't we drop this case? Nevermind, I see you're dropping it in the last patch. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
