Hi Andrew,

Andrew Lunn <and...@lunn.ch> writes:

>> @@ -3100,16 +3100,19 @@ char *mv88e6xxx_drv_probe(struct device *dsa_dev, 
>> struct device *host_dev,
>>      prod_num = (id & 0xfff0) >> 4;
>>      rev = id & 0x000f;
>>  
>> -    name = mv88e6xxx_lookup_name(id, table, num);
>> -    if (!name)
>> +    info = mv88e6xxx_lookup_info(prod_num, table, num);
>> +    if (!info)
>>              return NULL;
>>  
>> +    name = (char *) info->name;
>> +
>
> Hi Vivien
>
> Casting off the const is not so nice. How about adding in another
> patch to change the API to return a const char *.

OK.

Thanks,
Vivien

Reply via email to