On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote:
> Properly return rv back to the caller in the case of an error in
> parse_arg. In the process remove a unused variable 'out'.
The initial problem if I recall was value being uninitialized. Is that correct?
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com>
> ---
> drivers/platform/x86/asus-laptop.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c
> b/drivers/platform/x86/asus-laptop.c
> index d86d42e..9a69734 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
> const char *method)
> {
> int rv, value;
> - int out = 0;
>
> rv = parse_arg(buf, count, &value);
> - if (rv > 0)
> - out = value ? 1 : 0;
> + if (rv <= 0)
> + return rv;
>
> if (write_acpi_int(asus->handle, method, value))
> return -ENODEV;
> --
> 2.8.0
>
>
--
Darren Hart
Intel Open Source Technology Center
