Hi Moritz,
Thanks for the review...
> -----Original Message-----
> From: Moritz Fischer [mailto:[email protected]]
> Sent: Thursday, April 21, 2016 12:09 AM
> To: Appana Durga Kedareswara Rao <[email protected]>
> Cc: Rob Herring <[email protected]>; [email protected]; Mark Rutland
> <[email protected]>; Ian Campbell <[email protected]>;
> Kumar Gala <[email protected]>; Michal Simek <[email protected]>;
> Soren Brinkmann <[email protected]>; Vinod Koul <[email protected]>;
> Dan Williams <[email protected]>; Appana Durga Kedareswara Rao
> <[email protected]>; Laurent Pinchart
> <[email protected]>; Luis de Bethencourt
> <[email protected]>; Anirudha Sarangi <[email protected]>; Punnaiah
> Choudary Kalluri <[email protected]>; Devicetree List
> <[email protected]>; linux-arm-kernel <linux-arm-
> [email protected]>; Linux Kernel Mailing List <linux-
> [email protected]>; [email protected]
> Subject: Re: [PATCH 2/2] dmaengine: vdma: Add clock support
>
> Hi,
>
> thanks for looking into this.
>
> On Wed, Apr 20, 2016 at 12:20 AM, Kedareswara rao Appana
> <[email protected]> wrote:
>
> > +static int xdma_clk_init(struct xilinx_dma_device *xdev, bool enable)
> > +{
> > + int i = 0, ret;
> > +
> > + for (i = 0; i < xdev->numclks; i++) {
> > + if (enable) {
> > + ret = clk_prepare_enable(xdev->clks[i]);
> > + if (ret) {
> > + dev_err(xdev->dev,
> > + "failed to enable the axidma
> > clock\n");
> > + return ret;
>
> What happens to the ones you already turned on, if say the third fails?
Will fix in the next version of the patch...
Regards,
Kedar.
>
> Cheers,
>
> Moritz
This email and any attachments are intended for the sole use of the named
recipient(s) and contain(s) confidential information that may be proprietary,
privileged or copyrighted under applicable law. If you are not the intended
recipient, do not read, copy, or forward this email message or any attachments.
Delete this email message and any attachments immediately.
