On Mon, 2016-04-25 at 22:58 +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Add a missing space in dev_err message, missed because the string
> spans a few lines.
This is a dev_notice() not dev_err().
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
[]
> @@ -3345,7 +3345,7 @@ megasas_internal_reset_defer_cmds(struct
> megasas_instance *instance)
> if (!list_empty(&cmd->list)) {
> dev_notice(&instance->pdev->dev, "ERROR while"
> " moving this cmd:%p, %d %p, it was"
> - "discovered on some list?\n",
> + " discovered on some list?\n",
> cmd, cmd->sync_cmd, cmd->scmd);
>
> list_del_init(&cmd->list);
Better would be to coalesce the format, but perhaps
this dev_notice should be dev_err?
dev_notice(&instance->pdev->dev,
"ERROR while moving this cmd:%p, %d
%p, it was discovered on some list?\n",
cmd, cmd->sync_cmd, cmd->scmd);
And the message seems oddly phrased.
