3.16.35-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Linus Walleij <linus.wall...@linaro.org>

commit 95a001f22b1c5717eafd500a43832249ddd93662 upstream.

As of commit 876fe76d793d03077eb61ba3afab4a383f46c554
"mtd: maps: physmap: Add reference counter to set_vpp()"
the comment in the header file is incorrect and misleading.
Fix it up.

Cc: Russell King <li...@arm.linux.org.uk>
Cc: Paul Parsons <lost.dista...@yahoo.com>
Fixes: 876fe76d793d ("mtd: maps: physmap: Add reference counter to set_vpp()")
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
Signed-off-by: Brian Norris <computersforpe...@gmail.com>
Signed-off-by: Ben Hutchings <b...@decadent.org.uk>
---
 include/linux/mtd/map.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

--- a/include/linux/mtd/map.h
+++ b/include/linux/mtd/map.h
@@ -238,8 +238,11 @@ struct map_info {
           If there is no cache to care about this can be set to NULL. */
        void (*inval_cache)(struct map_info *, unsigned long, ssize_t);
 
-       /* set_vpp() must handle being reentered -- enable, enable, disable
-          must leave it enabled. */
+       /* This will be called with 1 as parameter when the first map user
+        * needs VPP, and called with 0 when the last user exits. The map
+        * core maintains a reference counter, and assumes that VPP is a
+        * global resource applying to all mapped flash chips on the system.
+        */
        void (*set_vpp)(struct map_info *, int);
 
        unsigned long pfow_base;

Reply via email to