On Fri 29-04-16 17:07:42, Minfei Huang wrote: > On 04/29/16 at 10:04P, Michal Hocko wrote: > > On Fri 29-04-16 13:47:04, Minfei Huang wrote: > > > It's more convenient to use existing function helper to convert string > > > "on/off" to boolean. > > > > But kstrtobool in linux-next only does "This routine returns 0 iff the > > first character is one of 'Yy1Nn0'" so it doesn't know about on/off. > > Or am I missing anything? > > Hi, Michal. > > Thanks for your reply. > > Following is the kstrtobool comment from linus tree, which has explained > that this function can parse "on"/"off" string. Also Kees Cook has > posted such patch to fix this issue as well. So I think it's safe to fix > it.
OK, I was looking at wrong tree and missed a81a5a17d44b ("lib: add "on"/"off" support to kstrtobool") Sorry about the confusion. Feel free to add Acked-by: Michal Hocko <mho...@suse.com> -- Michal Hocko SUSE Labs