On Tue, 2007-01-23 at 13:42 +0100, Haavard Skinnemoen wrote: > On 1/23/07, Daniel Walker <[EMAIL PROTECTED]> wrote: > > Update arch/avre32/ with list initialization. > > > > Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> > > Looks good to me, although I suppose it wouldn't hurt to include > <linux/list.h> as well since there seems to be an ongoing effort to > reduce the number of files that are included implicitly through other > headers. Might save us from some trouble later.
It shouldn't be outright implicit since it's included in clocksource.h . That has to be included before you can create a clocksource. I could see adding list.h if it wasn't clear which include was bringing it in. > I've closed your support request, so you shouldn't expect a reply from > [EMAIL PROTECTED] (I was going to reply through the support system, but > I couldn't figure out how to prevent it from top-quoting.) Probably > best if you send patches directly to me at [EMAIL PROTECTED], but > the support address is a nice fallback if I'm unable to respond for > some reason. I got that address from the maintainers file, AVR32 ARCHITECTURE P: Atmel AVR32 Support Team M: [EMAIL PROTECTED] P: Haavard Skinnemoen M: [EMAIL PROTECTED] W: http://www.atmel.com/products/AVR32/ W: http://avr32linux.org/ W: http://avrfreaks.net/ S: Supported I just picked the top address .. If it makes sense you might want to consider dropping that address from the maintainers file. It seems a little formal for submitting patches. In the future I'll send them to you. Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/