On Sat, Apr 30, 2016 at 6:24 AM, Borislav Petkov <[email protected]> wrote: > On Mon, Apr 25, 2016 at 02:53:14PM +0800, Minfei Huang wrote: >> The value of cycles and flags can be assigned directly without >> intermediate variables. >> >> Remove the useless variables. >> >> Signed-off-by: Minfei Huang <[email protected]> >> --- >> arch/x86/include/asm/pvclock.h | 15 ++++----------- >> 1 file changed, 4 insertions(+), 11 deletions(-) >> >> diff --git a/arch/x86/include/asm/pvclock.h b/arch/x86/include/asm/pvclock.h >> index fdcc040..fb95dac 100644 >> --- a/arch/x86/include/asm/pvclock.h >> +++ b/arch/x86/include/asm/pvclock.h >> @@ -80,19 +80,12 @@ static __always_inline >> unsigned __pvclock_read_cycles(const struct pvclock_vcpu_time_info *src, >> cycle_t *cycles, u8 *flags) >> { >> - unsigned version; >> - cycle_t ret, offset; >> - u8 ret_flags; >> - >> - version = src->version; >> + cycle_t offset; >> >> offset = pvclock_get_nsec_offset(src); > > You could go a step further and get rid of that > pvclock_get_nsec_offset() simple wrapper too and move its meat into > __pvclock_read_cycles()... >
Take a look at vread_pvclock. I decided that __pvclock_read_cycles was too ugly to use and was very slow and I just gave up and rewrote it. > -- > Regards/Gruss, > Boris. > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB > 21284 (AG Nürnberg) > -- -- Andy Lutomirski AMA Capital Management, LLC
