On Fri, May 6, 2016 at 3:10 AM, Ingo Molnar <[email protected]> wrote: > > * Borislav Petkov <[email protected]> wrote: > >> This can be simplified even further: >> >> --- >> From: Borislav Petkov <[email protected]> >> Date: Fri, 6 May 2016 10:43:21 +0200 >> Subject: [PATCH] x86/boot: Simplify pointer casting in >> choose_random_location() >> >> Pass them down as unsigned long directly and get rid of more casting and >> assignments. >> >> Signed-off-by: Borislav Petkov <[email protected]> >> Cc: Kees Cook <[email protected]> > >> arch/x86/boot/compressed/misc.h | 8 ++++---- >> 3 files changed, 12 insertions(+), 16 deletions(-) > > Great, thanks!
Thanks! Yeah, I did that originally, but then extract_kernel() was filled with casts, so I took a stab at it. I do prefer the casts being done in extract_kernel(), though. I was just worried Ingo won't like it. :) -Kees -- Kees Cook Chrome OS & Brillo Security
