On Mon, 2016-05-09 at 16:34 -0600, Toshi Kani wrote: > On Tue, 2016-05-10 at 07:19 +1000, Dave Chinner wrote: : > > > > > > > > > > This patch should replace blkdev_dax_capable(), or just reuse > > > > > that existing routine, or am I missing something? > > > > > > > > Good question. bdev_supports_dax() is a helper function tailored > > > > for the filesystem's mount -o dax case. While blkdev_dax_capable() > > > > is similar, it does not need error messages like "device does not > > > > support dax" since it implicitly enables dax when capable. So, I > > > > think we can keep blkdev_dax_capable(), but change it to call > > > > bdev_direct_access() so that actual check is performed in a single > > > > place. > > > > > > Sounds good to me. > > > > Can you name them consistently then? i.e. blkdev_dax_supported() and > > blkdev_dax_capable()? > > Sure. Will do.
I will keep the "bdev_" prefix to be consistent with bdev_direct_access(), i.e. bdev_dax_supported() and bdev_dax_capable(). -Toshi
