* Yinghai Lu <ying...@kernel.org> wrote: > On Mon, May 9, 2016 at 3:23 PM, Kees Cook <keesc...@chromium.org> wrote: > >> The exact reason to have assigning in functions. > >> > >> pgt_data address could be changed during kernel relocation. > >> so can not assigned during compiling time. > > > > Ah-ha, that explains why I had to keep it on the stack. Thanks for the > > clarification! > > My fault, I should put that comment in the code at first place.
Ok, could you guys please update the code and the changelog as well, and also rename that horribly named prepare_level4() function? Also, since this code is multi-author, it would be nice to add explicit copyright notices to the new arch/x86/boot/compressed/pagetable.c file, it was originally written by you, then modified by Kees. Something like: /* * Copyright (C) 2015-2016 Yinghai Lu * Copyright (C) 2016 Kees Cook */ Thanks, Ingo