On 05/11/2016 02:44 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/10/2016 04:09 PM, Krzysztof Kozlowski wrote: >> Configure Exynos5410-specific properties of RTC, I2C and HSI2C nodes. >> This still does not enable them on the board level though. >> >> Signed-off-by: Krzysztof Kozlowski <[email protected]> >> --- >> arch/arm/boot/dts/exynos5410.dtsi | 66 >> +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5410.dtsi >> b/arch/arm/boot/dts/exynos5410.dtsi >> index dd4d6d752865..ae64cb0a8efd 100644 >> --- a/arch/arm/boot/dts/exynos5410.dtsi >> +++ b/arch/arm/boot/dts/exynos5410.dtsi >> @@ -114,6 +114,9 @@ >> status = "disabled"; >> }; >> >> + /* i2c_0-3 are defined in exynos5.dtsi */ >> + /* hsi2c_4-7 are defined in exynos5xx.dtsi */ >> + > > I don't think these comments are needed. For each DTS, there are usually a > lot of > nodes defined in higher levels of the DT hierarchy but isn't common to > mention it. > > Specially since the mentioned nodes are referenced here by their labels so it > is > implicit that are defined in one of the included DTSI (or dtc will fail to > build).
Okay, if it does not make sense to you then I'll remove them. Thanks for review! Krzysztof
