From: Harvey Hunt <[email protected]>
Date: Tue, 10 May 2016 17:43:21 +0100
> @@ -1686,8 +1686,7 @@ dm9000_probe(struct platform_device *pdev)
> }
>
> if (!is_valid_ether_addr(ndev->dev_addr)) {
> - dev_warn(db->dev, "%s: Invalid ethernet MAC address. Please "
> - "set using ifconfig\n", ndev->name);
> + dev_warn(db->dev, "Invalid ethernet MAC address. Please set
> using ifconfig\n");
>
> eth_hw_addr_random(ndev);
> mac_src = "random";
If we don't print the netdev name, it's harder for the user to see which
adapter has the problem.
Therefore, it is better if you save some boolean state into a local variable
here, then print the warning right after register_netdev().
Likewise for the rest of your changes too.
