Hello Minchan,
On (05/14/16 08:05), Minchan Kim wrote:
[..]
> > recompress:
> > compress
> > handle = zs_malloc FAST PATH
> >
> > if (!handle) {
> > release stream
> > handle = zs_malloc SLOW PATH
> >
> > << my patch accounts SLOW PATH here >>
> >
> > if (handle) {
> > num_recompress++ << NEW version accounts it here, only
> > it was OK >>
> > goto recompress;
> > }
> >
> > goto err; << SLOW PATH is not accounted if SLOW PATH was
> > unsuccessful
> > }
> >
>
> I got your point. You want to account every slow path and change
> the naming from num_recompress to something to show that slow path.
yes :)
> Sorry for catching your point too late. And I absolutely agree with you.
> I want to name it with 'writestall' like MM's allocstall. :)
no problem. 'writestall' is really good, that's the word I was looking
for.
> Now I saw you sent new version but I like your suggestion more.
>
> I will send new verion by hand :)
> Thanks for the arguing. It was worth!
oh, thanks!
-ss
