On Tue, May 17, 2016 at 01:20:17PM +0000, Zhang, Rui wrote: > $checkpatch.pl 20-31-thermal-core-introduce-thermal_helpers.c.patch > > WARNING: added, moved or deleted file(s), does MAINTAINERS need > updating? > #187: > new file mode 100644 > > ERROR: trailing whitespace > #302: FILE: drivers/thermal/thermal_helpers.c:111: > + $ > > WARNING: please, no spaces at the start of a line > #302: FILE: drivers/thermal/thermal_helpers.c:111: > + $ > > total: 1 errors, 2 warnings, 287 lines checked > > NOTE: Whitespace errors detected. > You may wish to use scripts/cleanpatch or scripts/cleanfile > > 20-31-thermal-core-introduce-thermal_helpers.c.patch has style problems, > please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Please remove these spaces. > BTW, there are also some warnings in the other patches, please fix the > checkpatch warnings/errors.
Yeah, I will fix those. These patches were supposed to be reviewed/merged before the merge window though. I am going to wait until the merge window is closed to send them again. BR, Eduardo Valentin
