Hi Arnd, On Thu, 2016-05-19 at 13:04 +0300, Vladimir Zapolskiy wrote: > Hi Arnd, > > On 19.05.2016 11:35, Arnd Bergmann wrote: > > With the change to sparse IRQs, the lpc32xx platform gets a warning about > > conflicting macros: > > > > In file included from arch/arm/mach-lpc32xx/irq.c:31:0: > > arch/arm/mach-lpc32xx/include/mach/irqs.h:115:0: warning: "NR_IRQS" > > redefined > > #define NR_IRQS 96 > > arch/arm/include/asm/irq.h:9:0: note: this is the location of the previous > > definition > > #define NR_IRQS NR_IRQS_LEGACY > > > > In the irq controller driver, we surely need the local number instead of > > the generic NR_IRQS definition, so I'm renaming that one to LPC32XX_NR_IRQS. > > > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > > Fixes: 8cb17b5ed017 ("irqchip: Add LPC32xx interrupt controller driver") > > I think that the entire removal of arch/arm/mach-lpc32xx/irq.c is the proper > fix, > since it is a dead code now - > http://www.spinics.net/lists/arm-kernel/msg499976.html > > I believe you can apply that change and add Fixes: tag. >
I also submitted a patch that remove this warning at the source (GPIO driver broken to_irq support), until the GPIO driver update is done. Please refer to this link: http://thread.gmane.org/gmane.linux.kernel.gpio/16837 Sylvain > -- > With best wishes, > Vladimir