Hi Timur, Sricharan,
On 5/19/2016 2:21 PM, Timur Tabi wrote:
Naveen Kaje wrote:
+ tags[len++] = QUP_TAG_V2_DATARD;
+ /* 0 implies 256 bytes */
+ if (data_len == QUP_READ_LIMIT)
+ tags[len++] = 0;
+ else
+ tags[len++] = data_len;
+ }
Even data_len will always be '1' right ?
Yes, but here preferably we use a variable than a number without a
context.
Actually, I would say the opposite. I would rather see a constant
with a comment explaining it, than a variable that we know will always
contain only one number.
Ok, got it. Will be fixed in V3.
Thanks,
Naveen
