On 05/15/2016 08:49 AM, Masami Hiramatsu wrote:
Hi,
Here is the 8th version of the patchset for probe-cache and
initial SDT support.
The previous version is here; https://lkml.org/lkml/2016/5/11/446
This version I droped the second patch in v7 because it may
involves unintended behavior change and we'd better discuss it
out of this series. I also added comments why we can't use
access(R_OK) for /proc/kcore.
Hemant, could you review and test this series so that we can
proceed to your patch depending on this?
So, apart from the two issues which I mentioned in
the individual patches, it seems fine.
However, I think we will need a bit detailed documentation for the
probe cache feature as well as for the SDT support, given that we
have different commands to add {probe,sdt} events for a binary
and use them. I will write that that doc up based on your next
version.
Thank you,
---
Hemant Kumar (1):
perf/sdt: ELF support for SDT
Masami Hiramatsu (15):
perf buildid: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE
perf symbol: Cleanup the code flow of dso__find_kallsyms
perf-buildid-cache: Use path/to/bin/buildid/elf instead of
path/to/bin/buildid
perf probe: Add --cache option to cache the probe definitions
perf probe: Use cache entry if possible
perf probe: Show all cached probes
perf probe: Remove caches when --cache is given
perf probe: Add group name support
perf buildid-cache: Scan and import user SDT events to probe cache
perf probe: Accept %sdt and %cached event name
perf-list: Show SDT and pre-cached events
perf-list: Skip SDTs placed in invalid binaries
perf probe: Allow wildcard for cached events
perf probe: Support @BUILDID or @FILE suffix for SDT events
perf probe: Support a special SDT probe format
tools/perf/Documentation/perf-probe.txt | 26 +-
tools/perf/builtin-buildid-cache.c | 8
tools/perf/builtin-list.c | 4
tools/perf/builtin-probe.c | 30 ++
tools/perf/util/annotate.c | 2
tools/perf/util/build-id.c | 295 ++++++++++++++++--
tools/perf/util/build-id.h | 8
tools/perf/util/dso.h | 5
tools/perf/util/machine.c | 2
tools/perf/util/parse-events.c | 83 +++++
tools/perf/util/parse-events.h | 2
tools/perf/util/probe-event.c | 492 +++++++++++++++++++++++++++---
tools/perf/util/probe-event.h | 7
tools/perf/util/probe-file.c | 502 +++++++++++++++++++++++++++++++
tools/perf/util/probe-file.h | 41 +++
tools/perf/util/symbol-elf.c | 252 ++++++++++++++++
tools/perf/util/symbol.c | 73 ++---
tools/perf/util/symbol.h | 25 ++
18 files changed, 1719 insertions(+), 138 deletions(-)
--
Masami Hiramatsu
--
Thanks,
Hemant Kumar
