在 2016/5/20 20:57, Caesar Wang 写道:

于 2016年05月20日 20:35, Shawn Lin 写道:
在 2016/5/20 7:56, Caesar Wang 写道:
That's seem the incorrect string to match the spi driver.


Will it break the backward compatibility for some dtb if not
falling back to "rockchip,rockchip-spi" ?

The rk3036 shouldn't work if you read the driver/spi/spi-rockchip.c.
since the "rockchip,rockchip-spi" is *not* exist in linux kernel.


okay, so that means we take "rockchip,rockchip-spi" from local branch
by mistake?

..
 static const struct of_device_id rockchip_spi_dt_match[] = {
    { .compatible = "rockchip,rk3066-spi", },
    { .compatible = "rockchip,rk3188-spi", },
    { .compatible = "rockchip,rk3288-spi", },
    { .compatible = "rockchip,rk3399-spi", },
    { },
}
..


-Caesar


Fixes commit f629fcfab2cd
("ARM: dts: rockchip: support the spi for rk3036")

Signed-off-by: Caesar Wang <w...@rock-chips.com>
Cc: Heiko Stuebner <he...@sntech.de>
Cc: linux-rockc...@lists.infradead.org

---

Changes in v2: None

 arch/arm/boot/dts/rk3036.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk3036.dtsi
b/arch/arm/boot/dts/rk3036.dtsi
index d0f4bb7..a30700a 100644
--- a/arch/arm/boot/dts/rk3036.dtsi
+++ b/arch/arm/boot/dts/rk3036.dtsi
@@ -431,7 +431,7 @@
     };

     spi: spi@20074000 {
-        compatible = "rockchip,rockchip-spi";
+        compatible = "rockchip,rk3036-spi";
         reg = <0x20074000 0x1000>;
         interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
         clocks =<&cru PCLK_SPI>, <&cru SCLK_SPI>;








--
Best Regards
Shawn Lin

Reply via email to