On Mon, May 16, 2016 at 09:17:25AM -0700, Hoan Tran wrote:
> This patch adds the APM X-Gene hwmon device tree node documentation.
>
> Signed-off-by: Hoan Tran <hot...@apm.com>
> ---
> .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt | 14
> ++++++++++++++
> 1 file changed, 14 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
> b/Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
> new file mode 100644
> index 0000000..49a482e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
> @@ -0,0 +1,14 @@
> +APM X-Gene hwmon driver
> +
> +Hwmon driver accesses sensors over the "SLIMpro" mailbox.
DT bindings describe h/w, not driver data. I'm not sure this belongs in
DT and perhaps the devices for the mailbox should be created by the
mailbox driver.
> +
> +Required properties :
> + - compatible : should be "apm,xgene-slimpro-hwmon"
> + - mboxes : use the label reference for the mailbox as the first parameter.
> + The second parameter is the channel number.
When do you expect this to be different mailbox numbers?
> +
> +Example :
> + hwmonslimpro {
> + compatible = "apm,xgene-slimpro-hwmon";
> + mboxes = <&mailbox 7>;
> + };
> --
> 1.9.1
>
