On Sun, Jan 28, 2007 at 03:30:06PM +0000, Christoph Hellwig wrote: > On Sun, Jan 28, 2007 at 04:21:06PM +0100, Ingo Molnar wrote: > > > > sb->s_files is converted to a lock_list. furthermore to prevent the > > > > lock_list_head of getting too contended with concurrent add > > > > operations the add is buffered in per cpu filevecs. > > > > > > NACK. Please don't start using lockdep internals in core code. > > > > what do you mean by that? > > struct lock_list is an lockdep implementation detail and should not > leak out and be used anywhere else. If we want something similar it > should be given a proper name and a header of it's own, but I don't > think it's a valueable abstraction for the core kernel.
Christoph, "lock list" has nothing to do with lockdep. It's a relatively new data type used to construct concurrent linked lists using a spinlock per entry. bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
