> -----Original Message----- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Thursday, May 26, 2016 7:19 PM > To: Long Li <lon...@microsoft.com>; James E.J. Bottomley > <j...@linux.vnet.ibm.com>; Martin K. Petersen > <martin.peter...@oracle.com> > Cc: KY Srinivasan <k...@microsoft.com>; linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] Use the correct size to set block max sectors > > On 05/26/16 17:08, Long Li wrote: > > The block sector size should be in unit of 512 bytes, not in bytes. > > > > Signed-off-by: Long Li <lon...@microsoft.com> > > > > --- > > drivers/scsi/sd.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index > > 428c03e..4bce17e 100644 > > --- a/drivers/scsi/sd.c > > +++ b/drivers/scsi/sd.c > > @@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk) > > if (sdkp->opt_xfer_blocks && > > sdkp->opt_xfer_blocks <= dev_max && > > sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS && > > - sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) > > - rw_max = q->limits.io_opt = > > + sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) { > > + q->limits.io_opt = > > sdkp->opt_xfer_blocks * sdp->sector_size; > > + rw_max = (q->limits.io_opt >> 9); > > + } > > else > > rw_max = BLK_DEF_MAX_SECTORS; > > Isn't this a duplicate of a patch Martin Petersen posted three weeks ago? See > also > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fthread.g > mane.org%2fgmane.linux.scsi%2f113746&data=01%7c01%7clongli%40micros > oft.com%7c4396718e6f9749d178bf08d385d53bba%7c72f988bf86f141af91ab2 > d7cd011db47%7c1&sdata=UpiYwEdYMtqcwuNS1llVuXcQ6riFT3b5%2b44Sn56 > Bl14%3d. > > Bart. > >
Yes, this has been fixed in that patch. Please drop this one.
